Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: pin gdal"<=3.8" for circle ci #1235

Merged
merged 1 commit into from
Jul 24, 2024
Merged

tests: pin gdal"<=3.8" for circle ci #1235

merged 1 commit into from
Jul 24, 2024

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented Jul 23, 2024 •
edited
Loading

Description of proposed changes

  • circle ci: pin gdal"<=3.8" to fix the import error, which only occurrs in circle CI

  • tests/configs/SanFranBaySenD42: turn off tropo correction from pyaps

  • docs: use "HyP3" instead of "ASF HyP3"

Reminders

  • Fix Cannot import gdal in circle CI testing #1220
  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.

@yunjunz
tests: pin gdal"<=3.8" for circle ci
d9c0597 
+ circle ci: pin gdal"<=3.8" to fix the import error, which only occurrs in circle CI

+ tests/configs/SanFranBaySenD42: turn off tropo correction from pyaps

+ docs: use "HyP3" instead of "ASF HyP3"
@yunjunz yunjunz requested review from piyushrpt and jhkennedy July 23, 2024 07:58
@yunjunz
Copy link
Member Author

yunjunz commented Jul 23, 2024 •
edited
Loading

Hi @piyushrpt @jhkennedy, pinning gdal"<=3.8" seems to fix the gdal import error in the circle ci testing (#1220), although I don't know why. Shall we go ahead and merge this PR?

@scottstanie
Copy link
Contributor

Could be related to how the GDAL conda package did a huge split of its of dependencies so that you only get libgdal-core by default... That's definitely the biggest 3.9 change from GDAL on conda

piyushrpt
piyushrpt approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@piyushrpt piyushrpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yunjunz
Copy link
Member Author

yunjunz commented Jul 24, 2024 •
edited
Loading

Could be related to how the GDAL conda package did a huge split of its of dependencies so that you only get libgdal-core by default... That's definitely the biggest 3.9 change from GDAL on conda

@Xiaohua-Eric-Xu this may be the reason why gdal-3.9 could not read the GMT *.grd file's coordinate information properly, as we have seen in the short course last week.

@yunjunz yunjunz mentioned this pull request Jul 24, 2024
Open
@yunjunz
Copy link
Member Author

yunjunz commented Jul 24, 2024

Thank you @scottstanie for the info. I will go ahead and merge this PR first, and circle back to this (#1236) later.

@yunjunz yunjunz merged commit 5ca0cab into insarlab:main Jul 24, 2024
5 of 6 checks passed
@yunjunz yunjunz deleted the circleci branch July 24, 2024 07:50
@spestana spestana mentioned this pull request Aug 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piyushrpt piyushrpt piyushrpt approved these changes

@jhkennedy jhkennedy Awaiting requested review from jhkennedy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot import gdal in circle CI testing
3 participants
@yunjunz @scottstanie @piyushrpt